diff options
author | Joel Challis <git@zvecr.com> | 2019-10-29 01:00:03 +0000 |
---|---|---|
committer | Florian Didron <fdidron@users.noreply.github.com> | 2019-11-04 17:24:31 +0900 |
commit | 66d4c71b03d25b9d889f20bfa471de5fe037a428 (patch) | |
tree | b7e8d351db8b6cc24e78c5392bd8e12d06e86916 /drivers | |
parent | 0a3343aca90ea49e286d469c7c61ef4230f03552 (diff) |
Reduce duplication for ARM/AVR ws2812 RGB Matrix driver (#7180)
* Reduce duplication for ARM/AVR ws2812 rgb_matrix driver
* Reduce duplication for ARM/AVR ws2812 rgb_matrix driver - Fix setled_all use of r,g,b
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/avr/ws2812.c | 33 | ||||
-rw-r--r-- | drivers/avr/ws2812.h | 35 |
2 files changed, 11 insertions, 57 deletions
diff --git a/drivers/avr/ws2812.c b/drivers/avr/ws2812.c index 0a02c6f7fd..5c733c4ab0 100644 --- a/drivers/avr/ws2812.c +++ b/drivers/avr/ws2812.c @@ -25,13 +25,17 @@ #include <avr/interrupt.h> #include <avr/io.h> #include <util/delay.h> -#include "debug.h" -#if !defined(LED_ARRAY) && defined(RGB_MATRIX_ENABLE) -// LED color buffer -LED_TYPE led[DRIVER_LED_TOTAL]; -# define LED_ARRAY led -#endif +/* + * Forward declare internal functions + * + * The functions take a byte-array and send to the data output as WS2812 bitstream. + * The length is the number of bytes to send - three per LED. + */ + +void ws2812_sendarray(uint8_t *array, uint16_t length); +void ws2812_sendarray_mask(uint8_t *array, uint16_t length, uint8_t pinmask); + #ifdef RGBW_BB_TWI @@ -135,23 +139,6 @@ unsigned char I2C_Write(unsigned char c) { #endif -#ifdef RGB_MATRIX_ENABLE -// Set an led in the buffer to a color -void inline ws2812_setled(int i, uint8_t r, uint8_t g, uint8_t b) { - led[i].r = r; - led[i].g = g; - led[i].b = b; -} - -void ws2812_setled_all(uint8_t r, uint8_t g, uint8_t b) { - for (int i = 0; i < sizeof(led) / sizeof(led[0]); i++) { - led[i].r = r; - led[i].g = g; - led[i].b = b; - } -} -#endif - // Setleds for standard RGB void inline ws2812_setleds(LED_TYPE *ledarray, uint16_t leds) { // ws2812_setleds_pin(ledarray,leds, _BV(ws2812_pin)); diff --git a/drivers/avr/ws2812.h b/drivers/avr/ws2812.h index a9dd897185..9652b94bbe 100644 --- a/drivers/avr/ws2812.h +++ b/drivers/avr/ws2812.h @@ -20,13 +20,7 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -#ifndef LIGHT_WS2812_H_ -#define LIGHT_WS2812_H_ - -#include <avr/io.h> -#include <avr/interrupt.h> -//#include "ws2812_config.h" -//#include "i2cmaster.h" +#pragma once #include "quantum/color.h" @@ -42,33 +36,6 @@ * - Send out the LED data * - Wait 50�s to reset the LEDs */ -#ifdef RGB_MATRIX_ENABLE -void ws2812_setled(int index, uint8_t r, uint8_t g, uint8_t b); -void ws2812_setled_all(uint8_t r, uint8_t g, uint8_t b); -#endif - void ws2812_setleds(LED_TYPE *ledarray, uint16_t number_of_leds); void ws2812_setleds_pin(LED_TYPE *ledarray, uint16_t number_of_leds, uint8_t pinmask); void ws2812_setleds_rgbw(LED_TYPE *ledarray, uint16_t number_of_leds); - -/* - * Old interface / Internal functions - * - * The functions take a byte-array and send to the data output as WS2812 bitstream. - * The length is the number of bytes to send - three per LED. - */ - -void ws2812_sendarray(uint8_t *array, uint16_t length); -void ws2812_sendarray_mask(uint8_t *array, uint16_t length, uint8_t pinmask); - -/* - * Internal defines - */ -#ifndef CONCAT -# define CONCAT(a, b) a##b -#endif -#ifndef CONCAT_EXP -# define CONCAT_EXP(a, b) CONCAT(a, b) -#endif - -#endif /* LIGHT_WS2812_H_ */ |