summaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authorPete Sevander <pete.sevander@gmail.com>2020-07-16 15:39:01 +0300
committerJames Young <18669334+noroadsleft@users.noreply.github.com>2020-08-29 14:30:02 -0700
commitb0335b273142ead24cb4177893fafdf2fda88810 (patch)
treeb4f37b9f7aafe7525bda71a57d68e02cf1474946 /docs
parent93e7a8f74cc2c9c7bc50b413654642a0347a55d2 (diff)
Bigger combo index (#9318)
* Add change log * Change combo index from uint8_t to uint16_t
Diffstat (limited to 'docs')
-rw-r--r--docs/ChangeLog/20200829/PR9318.md11
1 files changed, 11 insertions, 0 deletions
diff --git a/docs/ChangeLog/20200829/PR9318.md b/docs/ChangeLog/20200829/PR9318.md
new file mode 100644
index 0000000000..c238f6e449
--- /dev/null
+++ b/docs/ChangeLog/20200829/PR9318.md
@@ -0,0 +1,11 @@
+### Bigger integer type when looping over combos.
+
+[#9318](https://github.com/qmk/qmk_firmware/pull/9318)
+
+Changes `uint8_t` to `uint16_t` so it is possible have more than 256 combos.
+
+Any fork that uses `process_combo_event` needs to update the function's first argument to `uint16_t`.
+
+| Old function | New Function |
+|---------------------------------------------------------------|----------------------------------------------------------------|
+| `void process_combo_event(uint8_t combo_index, bool pressed)` | `void process_combo_event(uint16_t combo_index, bool pressed)` |