diff options
| author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2022-09-29 21:28:12 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-30 05:28:12 +0100 |
| commit | dc7d2692c6de6e8d5ae11f9cab5f76bbbdbb9c49 (patch) | |
| tree | 932980079704edd5a634f0420c926765506cb468 | |
| parent | 83776b44b3ee7ff95cef9481dee023d98528e5e6 (diff) | |
Grammar Fix for PR Checklist (#18540)
* Grammar Fix for PR Checklist
* Update docs/pr_checklist.md
Co-authored-by: Nick Brassel <nick@tzarc.org>
* Update docs/pr_checklist.md, take 2
Co-authored-by: Nick Brassel <nick@tzarc.org>
| -rw-r--r-- | docs/pr_checklist.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 6d74e246a8..ed2b466de3 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -113,7 +113,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - submitters can also have a "manufacturer-matching" keymap that mirrors existing functionality of the commercial product, if porting an existing board - Do not include VIA json files in the PR. These do not belong in the QMK repository as they are not used by QMK firmware -- they belong in the [VIA Keyboard Repo](https://github.com/the-via/keyboards) - Do not include source files from another keyboard or vendors keyboard folder. Including core files is fine. - - For instance, only `wilba_tech` boards using be including `keyboards/wilba_tech/wt_main.c` and `keyboards/wilba_tech/wt_rgb_backlight.c`. But including `drivers/sensors/pmw3360.c` is absolutely fine. + - For instance, only `wilba_tech` boards shall include `keyboards/wilba_tech/wt_main.c` and `keyboards/wilba_tech/wt_rgb_backlight.c`. But including `drivers/sensors/pmw3360.c` is absolutely fine for any and all boards. - Code that needs to be used by multiple boards is a candidate for core code changes, and should be separated out. Also, specific to ChibiOS: |