summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCoffeeIsLife <36961653+CoffeeIsLife87@users.noreply.github.com>2022-07-02 07:49:49 -0500
committerGitHub <noreply@github.com>2022-07-02 22:49:49 +1000
commit0365f640af0a732366f1c71e86f6534629225161 (patch)
tree329b4c855f563f6d7b585235f583c94463883c18
parent4e35697e1a76a54f0ed756f98033535cf1322792 (diff)
Allow for RGB actions to take place on Keydown instead of Keyup (#16886)
* Allow for switch on keydown * add docs
-rw-r--r--docs/feature_rgb_matrix.md1
-rw-r--r--quantum/process_keycode/process_rgb.c4
2 files changed, 5 insertions, 0 deletions
diff --git a/docs/feature_rgb_matrix.md b/docs/feature_rgb_matrix.md
index 295e610fc4..b664ccd698 100644
--- a/docs/feature_rgb_matrix.md
+++ b/docs/feature_rgb_matrix.md
@@ -777,6 +777,7 @@ These are defined in [`color.h`](https://github.com/qmk/qmk_firmware/blob/master
#define RGB_MATRIX_DISABLE_KEYCODES // disables control of rgb matrix by keycodes (must use code functions to control the feature)
#define RGB_MATRIX_SPLIT { X, Y } // (Optional) For split keyboards, the number of LEDs connected on each half. X = left, Y = Right.
// If RGB_MATRIX_KEYPRESSES or RGB_MATRIX_KEYRELEASES is enabled, you also will want to enable SPLIT_TRANSPORT_MIRROR
+#define RGB_TRIGGER_ON_KEYDOWN // Triggers RGB keypress events on key down. This makes RGB control feel more responsive. This may cause RGB to not function properly on some boards
```
## EEPROM storage :id=eeprom-storage
diff --git a/quantum/process_keycode/process_rgb.c b/quantum/process_keycode/process_rgb.c
index c805bd615d..dae129786e 100644
--- a/quantum/process_keycode/process_rgb.c
+++ b/quantum/process_keycode/process_rgb.c
@@ -52,7 +52,11 @@ static void __attribute__((noinline, unused)) handleKeycodeRGBMode(const uint8_t
*/
bool process_rgb(const uint16_t keycode, const keyrecord_t *record) {
// need to trigger on key-up for edge-case issue
+#ifndef RGB_TRIGGER_ON_KEYDOWN
if (!record->event.pressed) {
+#else
+ if (record->event.pressed) {
+#endif
#if (defined(RGBLIGHT_ENABLE) && !defined(RGBLIGHT_DISABLE_KEYCODES)) || (defined(RGB_MATRIX_ENABLE) && !defined(RGB_MATRIX_DISABLE_KEYCODES))
uint8_t shifted = get_mods() & MOD_MASK_SHIFT;
#endif