Age | Commit message (Collapse) | Author |
|
Specifically, the lgreen variable isn't used, and avr-gcc 8.x complains about this. To prevent it from being an issue, just set all of these led variables to be unused.
|
|
This is the recommendation in the [PR
Checklist](https://docs.qmk.fm/#/pr_checklist?id=keyboard-prs) and it
will make working with them easier in the CLI/API/etc.
|
|
* add support for ModelM USB board
* EMI improvement: remove unnecessary toggling of MOSI pin
* address review comments
* Update keyboards/mschwingen/modelm/rules.mk
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/mschwingen/modelm/rules.mk
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/mschwingen/modelm/config.h
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/mschwingen/modelm/config.h
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/mschwingen/modelm/rules.mk
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Update keyboards/mschwingen/modelm/keymaps/default/keymap.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
* update printf usage
* add comment
* EMI improvement: remove unnecessary toggling of MOSI signal
* remove trailing space
* use shorter macros as suggested in review by noroadsleft, re-format table to line up columns
* Update keyboards/mschwingen/modelm/config.h
Co-authored-by: Ryan <fauxpark@gmail.com>
* Update keyboards/mschwingen/modelm/rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Update keyboards/mschwingen/modelm/rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Update keyboards/mschwingen/modelm/rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Update keyboards/mschwingen/modelm/README.md
Co-authored-by: Ryan <fauxpark@gmail.com>
* Update keyboards/mschwingen/modelm/README.md
Co-authored-by: Ryan <fauxpark@gmail.com>
* Apply suggestions from code review
use spi_read from core insteads of our own copy
Co-authored-by: Ryan <fauxpark@gmail.com>
* include spi_master.c to use spi_read()
* Update keyboards/mschwingen/modelm/README.md
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Apply suggestions from code review: correct indenting in keymap
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Apply suggestions from code review
use automatic variant defines from makefile instead of defining our own
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Update keyboards/mschwingen/modelm/rules.mk: use QUANTUM_LIB_SRC for uart.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Michael Schwingen <michael@schwingen.org>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
|