summaryrefslogtreecommitdiff
path: root/keyboards/keebio
AgeCommit message (Collapse)Author
2020-01-03more cleanupRossman360
2020-01-03cleanupRossman360
2020-01-03Add Levinson keymapRossman360
2020-01-02[Keymap] adding tf68 keymap, my first pull request. expecting there's lots ↵Rossman360
of bad practice, sorry (#7763) * adding tf68 keymap * had tf keymap in wrong folder * added tragicforce readme * cleaned up code * more cleanup * indent love and layer name change
2019-12-16Remove QMK_KEYBOARD_CONFIG_H from boards (#7635)Joel Challis
2019-12-06[Keyboard] Fix missing item in Ergodicity macro (#7553)Danny
2019-12-01[Keymap] Added jhelvy keymaps for keebio/iris and lily58 (#7447)John Helveston
* Added jhelvy keymaps for keebio/iris and lily58 * Fixed keymap image link for Iris * Update keyboards/keebio/iris/keymaps/jhelvy/keymap.c * Fixed keymap image url for lily58 * Update keyboards/lily58/keymaps/jhelvy/keymap.c * Removed numbers in parentheticals in lily58 rules * Removed unnecessary rules
2019-11-22[Keymap] Adding hbbisenieks keymap for keebio/iris (#7440)Hilary B. Brenum
* hbbisenieks keymap * fixed right encoder * changes suggested during pr
2019-11-21[Keyboard] Add three missing layouts (#7441)fauxpark
* Add three missing default layouts * Add layout support to tragicforce68 * Not really 68% * Fix dumb mistake * Update info.json too * Apply suggestions from code review
2019-11-21[Keymap] Add DZ60, Levinson keymaps, twschum user files (#7358)Tim Schumacher
* Adds layout for DZ60rev2 plate B, options 4 and 10 * Use KC_TRANS for layer keys * Format layer0 with visual key size layout * Add RGB controls; add start description; add KC_LOCK * Update comments on rules.mk for DZ60 * Gets keymap compiling * Fix wiring for shift on row 3 * Hold a with other key to send Ctrl-A before other key * Adds compile-time defined mac-compatability media keycodes * Adds logic in place for capturing taps (w/ timeout) * Add send_keys(...) which can send up to 64 nested keycodes * Implement send_keys callable with n repeats * Tweaks some of the keymap * Add reset keycode; add disable to custom shortcuts * Adds a special "off" layer where bonus mod goes to layer 0, every other key KC_NO * Adjust timeout; mousekey settings * Changes layout of Home,End,PgUp/Dn on the dedicated arrow keys L1/L2 * PoC on rgb lighted layer indication * Refactors color table defines * Adds logic for controlling layer lights * Only change state on one side of the event lol * Switch back to Tapping Toggle for layer 4 * Add custom config file for keyboard; TT and mousekey settings * Code cleanup; starting to refactor special ctrl tapping keys functions * Move defines and reak out functions * Remove debugging light * Adjust keymaps; add enter * Adds a couple custom macros * Add simplified version of keymap to help debug issues * Adds basi numpad configuration for levinson keyboard half * Use ANSI ctrl key as layer 1 for better one hand (`) * Adapt to new 8bit hue from #5547; layer enum use everywhere * Move custom code out to users/ space * Flip col pins, move key assignments to "left hand" * Update readme * Implement placeholder macros * Notes * Reduce tapping time for SFT_T(/) * Adds vim features; refactors things * Adds fork of the vim features written by xton * Use correct backspace keycode * Add VIM_ESC * Add "OFF" to the RGB/HSV definitions * Clean up rules, use new "OFF" definition * Add windows KC_CALCULATOR key to numpad * Reformat layers with better guide; change layer names * Add sleep key * Change timeout delay * Add a "code paste" which surrounds a ^V with ``` * Try removing shift tap on rshift / * Update macros * Update the "code paste" macro * Update keymap with reset, calc, equals * Update keyboards/dz60/keymaps/twschum_b_4_10_simple/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/dz60/keymaps/twschum_b_4_10/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update users/twschum/twschum.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update users/twschum/twschum.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Revert quantum/rgblight_list.h * Better name for split space layout; rename KEYMAP->LAYOUT * Rename KEYMAP->LAYOUT * Use simpler :flash command * Clean up layout files * Use qmk's MOD_MASK_CTRL * Sync lufa submodule * Cleanup from noroadsleft's PR comments * Modernize vim layer code
2019-11-20Remove keymap_config extern from default keymaps (#7399)Drashna Jaelre
* Remove keymap_config extern from default keymaps * Revert unicode Apparently VSCode does not like unicode, I didn't actually edit these lines, so it must have been automatic... :( Co-Authored-By: fauxpark <fauxpark@gmail.com>
2019-11-20[Keymap] All about (ARM) RGB and OLEDs (drashna keymaps) (#7354)Drashna Jaelre
* Add Kyria Keymap * Enable all RGBLIGHT Animations for ARM and high capacity AVR * Reduce GNUC version for __has_include * Cleanup Ortho 4x12 Community layout * Update Collide 39 keymap * Cleanup Keymaps * Enable full 30 LEDs for Ergodox * Change EEPROM Load timing * Use RGB Matrix on Planck Rev6 * Use correct keymap swap * Enable everything for ARM * Only enable rgb sleep on avr until crash is fixed * Add additional Kyria keymap config * Overhaul Kyria OLED display * Improve kyria keymap based on usage * Minor tweaks to rules * Update OLED code to truncate properly * Fix RGB Light layer indication * Switch all of biton32 to get_highest_layer function * Fix OLED Keylogger display * Run qmk cformat over all of my user files * Slight tweak to kyria based on usage * Move around LALT_T config * Add comments about base wrappers to keymaps * Another cformat pass * Temp fix for VUSB boards and NKRO * Convert tabs to spaces in rules.mk files * Only enable RGBLight if it's enabled * Add Encoder Flip setting * Update OLED font file
2019-11-08[Keymap] Adding keymaps for Niu Mini and BDN9 (#7299)codecoffeecode
* niu-mini * fix * media controls were off by one * Adding some function keys * bdn9 and some other stuff * Fixed mouse functions on bdn9 -- the acceleration related macros are NOT optional * ported over foo to codecoffeecode niu_mini keymap * removing foobar * removing foobar, moving config changes to my folder only * limiting rule changes to my folder * Simplifying config.h and rules.mk * not really sure why this didn't commit the first time but... * Fixed up the Niu Mini * Update keyboards/keebio/bdn9/keymaps/codecoffeecode/config.h Adding missed #pragma once to the top of my config.h for bdn9 Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com> * Switching from SEND_STRING() to tap_code16 * Simplifying -> didn't need macros for Ctrl+(Home|End)
2019-11-08[Keymap] Add issmirnov {user, ergodox, levinson} files. (#7239)Ivan Smirnov
* Add issmirnov {user, ergodox, levinson} files. There are enough interesting QMK tricks in these layouts that it seems worth it to share with the broader community. Big thanks to Drashna for inspiration, as well as all the wonderful creators of QMK documentation. Some highlights: - Common layout shared between levinson and ergodox_ez - TAP_TOG macro for fast layer switching - Autogenerated keymaps ascii art with git hooks I will do my best to do periodic rolls here, but the source of truth will always be https://github.com/issmirnov/qmk-keebs * Incorporate review feedback. - Remove CLEAR_EEPROM in favor of built in EEP_RST - Remove custom handlers for audio on bootup and shutdown - Remove plethora of unneeded includes - Remove deprecated and dupliated config options HUGE thanks to drashna for the review! * Apply suggestions from code review Huge thanks to drashna@ for a very thorough review and the very useful suggestions. Co-Authored-By: Drashna Jaelre <drashna@live.com> * Remove unclear optimization This was an artifact from some other keymap I saw.
2019-11-05Switch Quefrency to serial for independent halves (#7262)Jonathan Rascher
2019-11-04[Keymap] Add keymap for user jerryhcooke (#7251)Jerry Cooke
* Add keymap for user jerryhcooke Created a new keymap with encoder changing per layer * Added readme * Update readme.md * Update readme.md * Update readme.md * Update keyboards/keebio/iris/keymaps/jerryhcooke/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keymap.c * Fixed Formatting Ran automatic C formatting as suggested * Update rules.mk Fixed linespacing
2019-11-01[Keymap] Moar personal keymap and userspace tweaks (#7238)Jonathan Rascher
* Enable link-time optimization * Make RGB static gradient ranges shorter * Shift Quefrency media keys to the right * Shift KBD67 media keys to the right * Move some 60% keys from function to adjust layer * Set "extra" Lily58 keys to browser back/forward * Remove Instant60 EEPROM hack after #6968 * Remove unnecessary bits from macropad keymaps * Update KLE images
2019-10-29[Keyboard] Move Nyquist/Iris rules.mk files, update READMEs (#7196)Danny
* Migrate Nyquist rules.mk files to be version specific and update flash command * Migrate Iris rules.mk files to be version specific and update flash command
2019-10-29[Keymap] Update layout for my nyquist (#7188)Christoffer Holmberg
* Add layer for gaming without fancy Shift & Ctrl keys * Add default layer select to ARRW layer * Define layers with an enum to save fw space
2019-10-28[Keymap] Updating keymaps (#7170)Xyverz
* Added WOW layer * Initial commit for this branch. Still a work in progress. * Added Rorschach keyboard layout. * Simplified keymap Removed the media layer to help simplify things. Also corrected some keymap mistakes in the Qwerty and Colemak layers. * Added ErgoTravel keymap. * reverted to previous layout. * Added Sol keyboard layout. * Minor changes to keymap. * more changes * Added sol graphic by Kagerufu and Cardiactuna * Added colemak layer because I can. * more changes to sol layout * Streamlined Sol layout * minor tweaks to sol layout * further revisions to sol keymap. * Removing deprecated #include statements from my keymaps * Standardizing keymap `include` lines. * Minor change to keymap. Swapped ESC with GRV on all alpha layers. * Tweaks to Atreus62 Keymap Added a layer for FPS RPG Loot Shooters. * Fixed readme.md for Atreus keymap. Replaced "Keymap" with "Layer" in illustrations for continuity's sake * More readme.md clean-up More clarification in the Atreus readme file. * Next verse, same as the first. * Changes to Sol layout Bringing my Sol layout more in line with my other Orthos. * Fixed keymap GUI. Replaced left-hand "RGUI" with "LGUI" on all layers as it should be. * Added ALPS64 keymap * Formatting corrections * fixes to config.h and keymap.c * Fixed errors This commit fixes a pathing issue in keyboards/orthodox/keymaps/xyverz/config.h and removes an stupid comma at the end of each LAYOUT stanza in keyboards/rgbkb/sol/keymaps/xyverz/keymap.c left there by me. * Fixed orthodox keymap config.h file I hope this one fixes the problem. *sigh* * Making suggested changes for PR#6192 Thanks to noroadsleft, fauxpark, and drashna. Still have more work to do, but at least these suggestions have been applied. * Fixing build errors Travis has shown me the error of my ways... * More fixes and corrections Those pesky semicolons... * More Fixes. * Removing unneeded code snippet. * fixed omitted semicolons * Code updates to my keymaps Updating the code for my Iris, Atreus62, and Atreus keymaps. * Fixed Atreus62 Keymap I forgot to add in the aliases for LOWER, RAISE, and ADJUST. * Added userspace Also made changes to Atreus62 Keymap to turn the red LEDs off on the ProMicro * Fixing code that disables LEDs on ProMicros Also tidied up my ErgoTravel keymap. * Moving userspace to new branch Moving my userspace to a new branch for the sake of keeping things clean on the master branch. * Added F13-F15 to Atreus62 Layout. * Update readme.md. * Updated Phantom keymap to current keymap standards * Phantom keymap updates Further updates - tidying and removing cruft. Thank you zvecr on Discord for the help! * Standards Updates Bringing my Kinesis keymap up to current code standards * Adding a readme * Bring GH60 code to standard * Utilizing layouts for 60_ansi and tkl_ansi Moving my GH60 and Phantom keymaps into layouts/community/ * Alps64 layout removal Removing my Alps64 keymap now that I've setup my 60_ansi layout. * Moved Clueboard layout to community/66_ansi. * Additions to 66_ansi config.h * Bringing keymaps up to standard. * More updates to keymaps. * Syntax updates * Revert "Syntax updates" This reverts commit a892b2d9fcc0d4ba8fc22d676d5414120cc2c183. * Moved WIP keymaps Moved my WIP keymaps to my wip_keymaps branch to keep my master clean * Updates requested by noroadsleft * more changes per noroadsleft More fixes as requested by noroadsleft. Further tidy-up and standardization of my keymap code.
2019-10-22add bdn9/eosti keymap (#7105)Reid Sox-Harris
2019-10-21Cleanup rules.mk for 32U4 keyboards, I-K (#7097)fauxpark
* Cleanup rules.mk for 32U4 keyboards, I-K * Clean up ivy rules.mk
2019-10-21[Keymap] Ergodox EZ and dactyl-manuform keymaps for rishka (#7051)Adam Perlman
* Setup keymaps and userspace for Rishka * Creates a keymap for Ergodox Ez, bdn9 and Dactyl Manuform 5x6 * Update bdn9 config with suggested change * Add pragma to other header files * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com> * Updates from review from fauxpark * Updates from review Swap to keyboard_post_init, layer_state_t and use layer state for encoder * Updates from review Swap to keyboard_post_init, layer_state_t and use layer state for encoder * Add missing change from review
2019-10-20[Keymap] Assorted personal keymap and layout updates (#7082)Jonathan Rascher
* Enable PERMISSIVE_HOLD and TAPPING_FORCE_HOLD * Fix indentation in userspace * Shuffle around more Lily58 symbol keys * Reformat KBD67 keymap and KLE images * Fix Lily58 lower layer image * Reformat Quefrency keymap and KLE images * Fix KBD67 KLE images... again * Add KLE links for Quefrency * Reformat 60% layouts and KLE images * Move Super key back to right half of Lily58 * Move Lily58 ins/del out of the way of numbers * Fix bottom row of Lily58 KLE image
2019-10-20[Keymap] add iris/eosti keymap (#7056)Reid Sox-Harris
2019-10-16[Keymap] Drashna's Hardware Features Experimentations (#6920)Drashna Jaelre
* Change RGBLight pin for Planck Light Move it to A0, so that the SPI? pins are available for BT hackery * Add QMK DFU bootloader info * Add Solenoid * Disable annoying white LED on bottom * Enable Solenoid on Corne * Remove bounds for animations * Increase debounce for Ergodox EZ to reduce repeat key issues * Set swap hands key to be a hold-tap key This way, it's not ANNOYING and doesn't swap the hands inteniontally * Move MT Alt in Corne keymap * Re-Add fine tuned control of secrets * Squash mods to single row * Add LRA settings to haptic feedback settings for Rev6 * Fix issue with non-Planck EZ keymaps * Add 40 Percent Nano with Analog Joystick * Add Collide39 keymap * Fix OLED printing to be more flavorful * Fix up Iris GamePad and come cleanup * Expand OLED char map further * Add modded characters to keylogger * Here be dragons Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Fix up rules for community layouts * Some more OLED tweaks * Add mod mask check function * Change QMK DFU Audio pin to be correct * Use manual STM config instead of CTPC for Collide 39
2019-10-09[Keymap] Adding garyjzhao's Iris keymap (#6980)Gary Zhao
* Added Gary's user files * Added Gary's Iris Keymap files * Added Gary's Iris Keymap files * updated readme * removed comments * Cleaned up code even more
2019-10-05[Keymap] finally committing my updates (#6904)Matthew Lyon
2019-10-02[Keymap] Add antonlindstrom iris keymap (#6853)Anton Lindström
This adds a keymap for the Iris keymap for antonlindstrom. The keymap is based on the swedish keymap and thus contains the åäö characters.
2019-09-17[Keyboard] Fixed EEPROM start address for firmware using VIA (#6757)Wilba
2019-09-07[Keymap] Assorted personal keymap/userspace updates (#6691)Jonathan Rascher
* Turn off more unnecessary features by default * Double TAP_CODE_DELAY due to more media key issues Even with this change, some of the rotary encoder turns on my BDN9's volume knob still seem to get dropped. It's possible there's something wrong with the encoder itself. (Maybe the TAP_CODE_DELAY actually causes QMK to miss an encoder turn? Unclear.) The other knob (backlight brightness) works fine, FWIW.... * Restructure userspace config.h a bit * Hack around Instant60 Via EEPROM conflict Remove this when #6589 is fixed for Via boards. * Add backlight breathing and (EEPROM) reset to BDN9 * Add keymap for 9-Key macropad
2019-09-07[Keymap] Big Drashna code update (#6639)Drashna Jaelre
* Add a quefrency keymap * New Alt-ernate layouts * Enable Per Key Tapping Term to preserve sanity * Use underglow and mod lights for status on Corne * Update the drashna_ms keymap for quefrency * Disable Audio since there isn't enough space * Update KC_MAKE to ues :flash target * Cleanup ergodox layout * Enable i2c support for Iris * Add keymap support for CG_SWAP * Enable RGB Matrix Shutdown mode * enable heatmap * Update gitlab CI to install python3 * Remove game macros These are no longer needed, and haven't been used in ages * Cleanup planck layout * Add RGB Matrix fun and RGB cleanup * Add keycode and config for RGB Matrix idle animations * Clean up rgb idle animation code * Add rgb idle keycode to keymaps * Fix issues with rgb matrix idle animation * Fix some handling for idle animation * Reduce idle animation timeout to 15s to be more reasonable * fix up rgb stuff * Fix isses with rgb functions not being called for matrix * Use custom EEPROM Magic Number so testing is easier * Extend Default Layer macro to support a lot more layers * Fix bjohnson macropad * Adjust KC_MAKE to process mods for more consistent behavior * Fix up rgb stuff on corne * Corne OLED Overhaul * Fixes a number of issues with weirdness. * Fixes issues with keylogger (should be more reliable now) * Modulaize the OLED render sections * Rewrite layer display code * Update URL for Font Editor Due to odd issues, I ended up rewriting from scratch. And using PROGMEM versions, since I think I was getting memory overflows. * Update polling rate on all keebs * Fix planck ez layout config * Remove macros from Viterbi
2019-09-05[Keyboard] Add Iris Rev 4 (#6660)Danny
* Add Iris Rev. 4 * Fix EEPROM addresses
2019-09-03[Keyboard] Add Tukey board (#6657)Danny
2019-08-30[Keyboard] Assorted personal keymap/layout updates (#6621)Jonathan Rascher
* Switch Quefrency back to I2C (#6161 fixes the lag) * Update Quefrency keymap * Add reset and EEPROM reset keybindings so these tasks can be performed separately, rather than relying on Bootmagic Lite, which performs both tasks at the same time. * Move Caps Lock from Fn+Ctrl to Fn+Tab since Fn+Ctrl is sometimes used as part of a more complex keybinding, whereas Fn+Tab is always safe. * Update KBD67 keymap * Add reset and EEPROM reset keybindings so these tasks can be performed separately, rather than relying on Bootmagic Lite, which performs both tasks at the same time. * Move Caps Lock from Fn+Ctrl to Fn+Tab since Fn+Ctrl is sometimes used as part of a more complex keybinding, whereas Fn+Tab is always safe. * Move Menu to a layer tap on the Fn key since that's a more natural location. * Update 60% Tsangan HHKB layout * Move Caps Lock from Fn+Ctrl to Fn+Tab since Fn+Ctrl is sometimes used as part of a more complex keybinding, whereas Fn+Tab is always safe. * Update 60% ANSI split backspace/right-shift layout * Add reset and EEPROM reset keybindings so these tasks can be performed separately, rather than relying on Bootmagic Lite, which performs both tasks at the same time. * Move Caps Lock from Fn+Ctrl to Fn+Tab since Fn+Ctrl is sometimes used as part of a more complex keybinding, whereas Fn+Tab is always safe.
2019-08-30[Keyboard] Add option to use 4x12 layout for Nyquist (#6633)Danny
* Add option to use 4x12 layout for Nyquist * Add 4x12 Nyquist support to configurator * Add height to 4x12 configurator layout Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Remove QWERTY keycode Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
2019-08-30Remove KC_DELT alias in favor of KC_DEL (#6327)Konstantin Đorđević
* Remove KC_DELT alias in favor of KC_DEL * Add changelog
2019-08-30Update swedish based keymaps with newer keycodesDrashna Jaelre
2019-08-30Migrate ACTION_LAYER_MOMENTARYs to MO() (#5176)fauxpark
* Migrate ACTION_LAYER_MOMENTARYs to MO() * Add changelog entry * Update docs/ChangeLog/20190830/PR5176.md Co-Authored-By: skullydazed <skullydazed@users.noreply.github.com>
2019-08-21Remove old promicro_bootloader_jmp() declarations (#6444)fauxpark
2019-08-13[Keymap] Adding my userspace and keymaps (#6496)Seth Barberee
* add Userspace and keymaps * Adding keymaps for zeal60 and iris * Created my own tap dance that toggles RGB Mode based on whether I toggled caps lock or not * parent 578ed42a7f8f986147cad040d50d4ae1d24a32e2 author Seth Barberee <seth.barberee@gmail.com> 1565065903 -0500 committer Seth Barberee <seth.barberee@gmail.com> 1565065903 -0500 move to userspace add zeal60 * update based on review * move userspace to github name
2019-08-10update arrows on lower layer (#6517)George Petri
2019-08-07Update gaming layout (#6504)Matthew Treadwell
2019-08-01[Keymap] Adds Keymap for Iris/blucky (#6449)Brian L
* Adds Keymap for Iris/blucky * code review changes * removed custom define * removed mistyped character
2019-07-30[Keymap] Added keymap folder matching username to rorschach; added readme to ↵tuesdayjohn
old keympa (#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
2019-07-28[Keymap] Shift RGB layout keys to the right by one to be consistent with ↵Sid Carter
other keymap layouts (#6431) * move rgb toggles by one key to be consistent with all other keyboard layouts I have * also remove unnecessary audio stuff
2019-07-23[Keyboard] Add ergodicity (#6396)Danny
* Initial addition of Ergodicity * Add QMK configurator JSON
2019-07-22[Keymap] Drashna's Feature madness (#6128)Drashna Jaelre
* Fix my Tap Dance issues after I broke them * Cleanup and organization of userspace documentation As well as some additional cleanup of functions due to review of documentation. * Enable Tapdance on Glow and remove more animations * Revert to Eager PR debouncing * Add better check for startup animation * Move where RGB Matrix defines are listed * Limit RGB Matrix max val * Update keyboard for Iris Rev 3 conflicts * Enable encoder support on planck ez * Remove is_master check from corne\'s OLED code * Overhaul OLED screens for my Corne * One last removal * Show RGB valu On both sides * Updates for OLED display info * Fix compile issues for rgb config * Disabled Space Cadet for all drashna keymaps * Fix OLED Screen configs * Minor OLED Tweaks * Revert some Iris changes * Fix song include * Handle MAKE macro for the Corne boards better * Add super hacky-hack for eeconfig initialization * Add audio support for Fractal since Elite Cs support it * Add defines for keycode steps * Add White layout * Update Corne RGB info * Add fun effects to layer indication for RGB Matrix enabled boards * Use proper define for product name detection * Update formatting * Use custom timeout mechanism for OLED timeout * Fix up OLED screen HSV code for new HSV structure * Better handle turning off RGB Matrix when sleeping * Disable MultiSplash Animation * Change Iris back to using serial * Why was RGB disabled?!?!?! * Limit val in rgb_matrix_layer_helper function * Remove EECONFIG setting for RGB matrix
2019-07-22[Keymap] Update keymap for keebio/quefrency 65% version (#6388)George Petri
* minor keymap changes * minor keymap changes update readme * update rules.mk * add rgb * add add arrows in hjkl * removed backslashes * fix missing comma * spacing fix * minor cleanup * add r layer * impl navigation layer * moved backspace nearby * updated readme
2019-07-22[Keymap] Switch Iris keymap from workman to colemak (#6385)Sid Carter
* via support and colemak layout * figures tap and hold parts don't work vith via enabled - so those are commented out for now