summaryrefslogtreecommitdiff
path: root/tmk_core/common
diff options
context:
space:
mode:
authorridingqwerty <george.g.koenig@gmail.com>2020-02-25 13:25:52 -0500
committerDrashna Jael're <drashna@live.com>2020-03-26 00:42:13 -0700
commit4dc91caf4eb06bc0d17bf189001ce6099afad6ce (patch)
treef82dd28e60d906918e821b9b32e73b0442bc5d0e /tmk_core/common
parent28f45b8ff4073528ad8a665e1471ca5e927759e8 (diff)
New feature: PERMISSIVE_HOLD_PER_KEY (#7994)
* Implement 'PERMISSIVE_HOLD_PER_KEY' * Document 'PERMISSIVE_HOLD_PER_KEY' Co-authored-by: GeorgeKoenig <35542036+GeorgeKoenig@users.noreply.github.com>
Diffstat (limited to 'tmk_core/common')
-rw-r--r--tmk_core/common/action_tapping.c16
1 files changed, 11 insertions, 5 deletions
diff --git a/tmk_core/common/action_tapping.c b/tmk_core/common/action_tapping.c
index c0f1f694b7..acce3ee515 100644
--- a/tmk_core/common/action_tapping.c
+++ b/tmk_core/common/action_tapping.c
@@ -31,6 +31,10 @@ __attribute__((weak)) uint16_t get_tapping_term(uint16_t keycode) { return TAPPI
__attribute__((weak)) bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) { return false; }
# endif
+# ifdef PERMISSIVE_HOLD_PER_KEY
+__attribute__((weak)) bool get_permissive_hold(uint16_t keycode, keyrecord_t *record) { return false; }
+# endif
+
static keyrecord_t tapping_key = {};
static keyrecord_t waiting_buffer[WAITING_BUFFER_SIZE] = {};
static uint8_t waiting_buffer_head = 0;
@@ -115,13 +119,15 @@ bool process_tapping(keyrecord_t *keyp) {
* This can register the key before settlement of tapping,
* useful for long TAPPING_TERM but may prevent fast typing.
*/
-# if defined(TAPPING_TERM_PER_KEY) || (TAPPING_TERM >= 500) || defined(PERMISSIVE_HOLD)
+# if defined(TAPPING_TERM_PER_KEY) || (TAPPING_TERM >= 500) || defined(PERMISSIVE_HOLD) || defined(PERMISSIVE_HOLD_PER_KEY)
+ else if (
# ifdef TAPPING_TERM_PER_KEY
- else if ((get_tapping_term(get_event_keycode(tapping_key.event)) >= 500) && IS_RELEASED(event) && waiting_buffer_typed(event))
-# else
- else if (IS_RELEASED(event) && waiting_buffer_typed(event))
+ (get_tapping_term(get_event_keycode(tapping_key.event)) >= 500) &&
+# endif
+# ifdef PERMISSIVE_HOLD_PER_KEY
+ !get_permissive_hold(get_event_keycode(tapping_key.event), keyp) &&
# endif
- {
+ IS_RELEASED(event) && waiting_buffer_typed(event)) {
debug("Tapping: End. No tap. Interfered by typing key\n");
process_record(&tapping_key);
tapping_key = (keyrecord_t){};