diff options
| author | XScorpion2 <rcalt2vt@gmail.com> | 2019-05-01 13:36:50 -0500 |
|---|---|---|
| committer | Drashna Jaelre <drashna@live.com> | 2019-05-01 13:27:44 -0700 |
| commit | 2351739cd9f2b9f82725fceb102f6a2bc768ebf6 (patch) | |
| tree | 3aabe9f9cee1b7ab563bed506f0cb074e61385d1 /quantum/rgb_matrix_animations | |
| parent | 59d28fe2884c0639ef020ece3e1bc6967ab0881f (diff) | |
Simple fix for selecting which tracked key press to work off of for simple reactive effects (#5745)
Diffstat (limited to 'quantum/rgb_matrix_animations')
| -rw-r--r-- | quantum/rgb_matrix_animations/solid_reactive_anim.h | 3 | ||||
| -rw-r--r-- | quantum/rgb_matrix_animations/solid_reactive_simple_anim.h | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/quantum/rgb_matrix_animations/solid_reactive_anim.h b/quantum/rgb_matrix_animations/solid_reactive_anim.h index 220e542331..1116bb055c 100644 --- a/quantum/rgb_matrix_animations/solid_reactive_anim.h +++ b/quantum/rgb_matrix_animations/solid_reactive_anim.h @@ -14,7 +14,8 @@ bool rgb_matrix_solid_reactive(effect_params_t* params) { // Relies on hue being 8-bit and wrapping for (uint8_t i = led_min; i < led_max; i++) { uint16_t tick = max_tick; - for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) { + // Reverse search to find most recent key hit + for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) { if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) { tick = g_last_hit_tracker.tick[j]; break; diff --git a/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h b/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h index e84cd69392..a2d3f242c1 100644 --- a/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h +++ b/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h @@ -13,7 +13,8 @@ bool rgb_matrix_solid_reactive_simple(effect_params_t* params) { uint16_t max_tick = 65535 / rgb_matrix_config.speed; for (uint8_t i = led_min; i < led_max; i++) { uint16_t tick = max_tick; - for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) { + // Reverse search to find most recent key hit + for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) { if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) { tick = g_last_hit_tracker.tick[j]; break; |