summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoresinlayo <esinlayo@gmail.com>2020-02-07 18:52:02 -0800
committerGitHub <noreply@github.com>2020-02-07 18:52:02 -0800
commit7182e9a8ad5e5baa36be5c032c16923396838b3f (patch)
tree0c8a205cb12cf45bc9c1877c47a873aaab772de0
parent3b1f29a5d6d171c7c659eb0d76fff806a52ac1cf (diff)
[Keyboard] Remove i2c write command when reading columns on Ergodox EZ (#8092)
* Remove i2c write command when reading cols on Ergodox EZ * Comment on mcp23018 address state during read_cols
-rw-r--r--keyboards/ergodox_ez/matrix.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/keyboards/ergodox_ez/matrix.c b/keyboards/ergodox_ez/matrix.c
index c707729380..28dc37a099 100644
--- a/keyboards/ergodox_ez/matrix.c
+++ b/keyboards/ergodox_ez/matrix.c
@@ -208,10 +208,8 @@ static matrix_row_t read_cols(uint8_t row) {
return 0;
} else {
uint8_t data = 0;
- mcp23018_status = i2c_start(I2C_ADDR_WRITE, ERGODOX_EZ_I2C_TIMEOUT);
- if (mcp23018_status) goto out;
- mcp23018_status = i2c_write(GPIOB, ERGODOX_EZ_I2C_TIMEOUT);
- if (mcp23018_status) goto out;
+ // reading GPIOB (column port) since in mcp23018's sequential mode
+ // it is addressed directly after writing to GPIOA in select_row()
mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT);
if (mcp23018_status) goto out;
mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT);