summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorskullY <skullydazed@gmail.com>2019-11-23 10:42:39 -0800
committerFlorian Didron <fdidron@users.noreply.github.com>2020-01-09 08:57:11 +0900
commit0f1f9ba155b126976b0ced279676188060f0015f (patch)
tree23548f2efe55c504cd2ca2172038d40cb888966f
parentac75812e50f25b8ca262688f99177f11d5b17441 (diff)
Add pep8-naming to our python linting
-rwxr-xr-xbin/qmk5
-rwxr-xr-xlib/python/qmk/cli/doctor.py2
-rw-r--r--lib/python/qmk/tests/test_qmk_errors.py2
-rw-r--r--requirements.txt1
4 files changed, 8 insertions, 2 deletions
diff --git a/bin/qmk b/bin/qmk
index b42f6b6e23..70e6d53fd2 100755
--- a/bin/qmk
+++ b/bin/qmk
@@ -25,6 +25,11 @@ with open(os.path.join(qmk_dir, 'requirements.txt'), 'r') as fd:
line = line.split('#')[0]
module = line.split('=')[0] if '=' in line else line
+
+ if module in ['pep8-naming']:
+ # Not every module is importable by its own name.
+ continue
+
if not find_spec(module):
print('Could not find module %s!', module)
print('Please run `pip3 install -r requirements.txt` to install the python dependencies.')
diff --git a/lib/python/qmk/cli/doctor.py b/lib/python/qmk/cli/doctor.py
index 1010eafb33..2421e520e0 100755
--- a/lib/python/qmk/cli/doctor.py
+++ b/lib/python/qmk/cli/doctor.py
@@ -39,7 +39,7 @@ def doctor(cli):
ok = False
# Determine our OS and run platform specific tests
- OS = platform.system()
+ OS = platform.system() # noqa (N806), uppercase name is ok in this instance
if OS == "Darwin":
cli.log.info("Detected {fg_cyan}macOS.")
diff --git a/lib/python/qmk/tests/test_qmk_errors.py b/lib/python/qmk/tests/test_qmk_errors.py
index 1d8690b7ef..948e7ef741 100644
--- a/lib/python/qmk/tests/test_qmk_errors.py
+++ b/lib/python/qmk/tests/test_qmk_errors.py
@@ -1,7 +1,7 @@
from qmk.errors import NoSuchKeyboardError
-def test_NoSuchKeyboardError():
+def test_nosuchkeyboarderror():
try:
raise NoSuchKeyboardError("test message")
except NoSuchKeyboardError as e:
diff --git a/requirements.txt b/requirements.txt
index 033b688fc6..074b11a8ce 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -6,3 +6,4 @@ colorama
hjson
nose2
flake8
+pep8-naming