From 4f5c76bfbefe0141858ec7eec15f790318c2e477 Mon Sep 17 00:00:00 2001 From: Erovia Date: Sun, 5 Apr 2020 11:17:12 +0200 Subject: Fix edge-case with config Without this check, users can lock themselves out by enabling developer mode, than disabling the dependencies. They wouldn't be able to turn off developer mode as none of the subcommands (including 'config') would work. --- bin/qmk | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bin/qmk b/bin/qmk index 121aec4b3b..750ff2bdb7 100755 --- a/bin/qmk +++ b/bin/qmk @@ -4,7 +4,6 @@ import os import sys from importlib.util import find_spec -from time import strftime from pathlib import Path # Add the QMK python libs to our path @@ -52,9 +51,11 @@ import milc # noqa # For developers additional modules are needed if milc.cli.config.user.developer: - developer = True - _check_modules('requirements-dev.txt') - + # Do not run the check for 'config', + # so users can turn off developer mode + if len(sys.argv) == 1 or (len(sys.argv) > 1 and 'config' != sys.argv[1]): + developer = True + _check_modules('requirements-dev.txt') milc.EMOJI_LOGLEVELS['INFO'] = '{fg_blue}Ψ{style_reset_all}' -- cgit v1.2.3